Skip to content

Refactor: Introduce parameter objects to reduce function arguments in ProcessingClips.cs#4

Open
Copilot wants to merge 4 commits intoproductionfrom
copilot/refactor-processing-clips-arguments
Open

Refactor: Introduce parameter objects to reduce function arguments in ProcessingClips.cs#4
Copilot wants to merge 4 commits intoproductionfrom
copilot/refactor-processing-clips-arguments

Conversation

Copy link

Copilot AI commented Nov 14, 2025 •
edited
Loading

Three methods in ProcessingClips.cs exceeded the C# threshold of 4 arguments (all had 5), indicating missing abstractions.

Changes

New Parameter Objects

  • ProcessingOptions: Encapsulates Mode, Placeholder, and CaseInsensitive (all with defaults)
  • PatchOptions: Encapsulates Mode and Placeholder

Refactored Methods

  • ProcessClipsAsync: 5 → 3 parameters
  • ProcessSingleClipAsync: 5 → 3 parameters
  • ApplyPatch: 5 → 4 parameters

Before/After

// Before
public async Task<ProcessingResult> ProcessClipsAsync(
    List<string> clipFilePaths, 
    List<string> blockedResources,
    PatchMode mode = PatchMode.Null, 
    string placeholder = "REMOVED", 
    bool caseInsensitive = false)

// After
public async Task<ProcessingResult> ProcessClipsAsync(
    List<string> clipFilePaths,
    List<string> blockedResources,
    ProcessingOptions options = null)

Call sites updated in Application.cs to construct ProcessingOptions object.

Original prompt

This section details on the original issue you should resolve

<issue_title>[T_DEBT] clip2load-repository/ProcessingClips.cs - ProcessClipsAsync + ProcessSingleClipAsync + ApplyPatch</issue_title>
<issue_description># Where?
This file has 3 functions that exceed the maximum number of arguments.

Why does this problem occur?

Functions with many arguments indicate either a) low cohesion where the function has too many responsibilities, or b) a missing abstraction that encapsulates those arguments.

The threshold for the C# language is 4 function arguments.

How to fix it?

Start by investigating the responsibilities of the function. Make sure it doesn't do too many things, in which case it should be split into smaller and more cohesive functions. Consider the refactoring INTRODUCE PARAMETER OBJECT to encapsulate arguments that refer to the same logical concept.</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits November 14, 2025 12:15
@Avenze
Refactor: Introduce parameter objects to reduce function arguments
b2fe11c 
Co-authored-by: Avenze <38162785+Avenze@users.noreply.github.com>
@Avenze
Final verification complete
f8b7b31 
Co-authored-by: Avenze <38162785+Avenze@users.noreply.github.com>
@Avenze
Remove build artifacts from tracking (obj directory)
d98e653 
Co-authored-by: Avenze <38162785+Avenze@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor functions in ProcessingClips.cs to reduce arguments Refactor: Introduce parameter objects to reduce function arguments in ProcessingClips.cs Nov 14, 2025
Copilot AI requested a review from Avenze November 14, 2025 12:20
@Avenze Avenze marked this pull request as ready for review November 14, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avenze Avenze Awaiting requested review from Avenze

Assignees

@Avenze Avenze

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[T_DEBT] clip2load-repository/ProcessingClips.cs - ProcessClipsAsync + ProcessSingleClipAsync + ApplyPatch

2 participants

@Avenze